Decouple broker and coordinator interface #6675
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lledError not needed
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
3 times, most recently
from
cff69d3 to
b1f446a
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
afc0925 to
28cdb1c
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
3 times, most recently
from
e613a3b to
5d59e6a
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
c6c6352 to
c769906
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
abaf3e9 to
03f7a5b
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
ca1dd09 to
02a939e
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
fe92318 to
329c51c
Compare
When calling add_rpc_subscriber and add_task_subscriber, the event loop of caller may from random event loop. But the target event loop is the runner one. Therefore it requires to pass the loop to the broker when creating the runner and runner's broker.
for more information, see https://pre-commit.ci
Instead of as a method of runner which is not needed and confuse.
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
9583218 to
69db549
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
a08471c to
5746ae8
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
5572660 to
d62816e
Compare
unkcpz
force-pushed
the
rmq-out-small-step-try
branch
from
ccf4af2 to
d62816e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runner with dedicated thread(need more experiments)broker and coordinator are duplicate abstraction, remove brokerthis should be done after, in this change, it bring coordinator layer first to not break the broker abstraction introduced (which is not real abstraction and relatively useless).